Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update args json #54

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Update args json #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0305b8a
update template code chunks args JSON
sisyphusSmiling Apr 26, 2024
9cc0dca
fix typos
sisyphusSmiling Apr 26, 2024
2164a0e
update PR template
sisyphusSmiling Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ ______

For contributor use:

- [ ] Targeted PR against `master` branch
- [ ] Targeted PR against `main` branch
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [standards mentioned here](https://github.com/onflow/flow-evm-bridge/blob/master/CONTRIBUTING.md#styleguides).
- [ ] Updated relevant documentation
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ return true.
In both cases, `allowsBridging()` gates onboarding to the bridge. Once onboarded - **a permissionless operation anyone can
execute** - the value of `allowsBridging()` is irrelevant and assets can move between VMs permissionlessly.

## Under the Hood (facilitating cross-vm interactions)
## Under the Hood

For an in-depth look at the high-level architecture of the bridge, see [FLIP
#237](https://github.com/onflow/flips/pull/233)
Expand Down
15 changes: 6 additions & 9 deletions cadence/args/bridged-nft-code-chunks-args-emulator.json
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions cadence/args/bridged-nft-code-chunks-args-previewnet.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions cadence/args/bridged-token-code-chunks-args-emulator.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions cadence/args/bridged-token-code-chunks-args-previewnet.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion cadence/contracts/bridge/interfaces/CrossVMNFT.cdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import "MetadataViews"

import "EVM"

/// Contract defining cross-VM NFT-related interfaces & Metadata views
/// Contract defining cross-VM NFT-related interfaces
///
access(all) contract CrossVMNFT {

Expand Down
Loading