Extract the RLP and remove go-ethereum dependency #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 9, 2022 12:26
git-subtree-dir: rlp git-subtree-split: 594e32166269eed4f5cb8270bba99fa234a41606
sideninja
requested review from
psiemens,
turbolent and
janezpodhostnik
as code owners
|
@sideninja I'm trying to understand what is missing here? I can follow up on missing bits if you don't mind. |
|
@nozim it's pretty much done, but I wanted to make sure everything was correct but just then didn't have time. I would say making sure this way is the right way. |
|
I think cutting dependency while keeping same functionality is already good for this scope. So should be good to merge :) |
|
We need to make sure it is updated too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #221
Description
This PR extracts the RLP implementation of the go-etheruem package.
It uses git subtree to include the repository and allow updates with the upstream branch. The contents were modified to only include the RLP implementation and remove all the unnecessary files.
I was trying to use git submodule but I had problems due to the fact that it only referenced a whole subrepo as a commit reference, but that commit wasn't really pushed to the ethereum repo for obvious reasons.
DOD:
For contributor use:
masterbranchFiles changedin the Github PR explorer