Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify streaming endpoints code duplication #763

Closed
illia-malachyn opened this issue Sep 20, 2024 · 1 comment · Fixed by #781
Closed

Unify streaming endpoints code duplication #763

illia-malachyn opened this issue Sep 20, 2024 · 1 comment · Fixed by #781
Assignees
@illia-malachyn

Comments

@illia-malachyn
Copy link
Contributor

illia-malachyn commented Sep 20, 2024 •
edited
Loading

We need to do a small refactoring to get rid of code duplications caused by streaming endpoints introduction in #735 epic

Check out these PRs to understand the code similarities
#762
#760
#758

Note: it should be done after those PRs are merged in
@illia-malachyn
Copy link
Contributor Author

@peterargue cc

@illia-malachyn illia-malachyn changed the title Unify streaming endpoints code Unify streaming endpoints code duplication Sep 23, 2024
@illia-malachyn illia-malachyn mentioned this issue Sep 25, 2024
Merged
@lealobanov lealobanov mentioned this issue Oct 4, 2024
Closed
@illia-malachyn illia-malachyn mentioned this issue Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@illia-malachyn illia-malachyn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor subscribe func and stream mock object The-K-R-O-K/flow-go-sdk
1 participant
@illia-malachyn