Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NopDropout elimination replaces mask usage by input #40

Open
Flamefire opened this issue Apr 16, 2021 · 1 comment
Open

NopDropout elimination replaces mask usage by input #40

Flamefire opened this issue Apr 16, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@Flamefire
Copy link

In https://github.com/onnx/onnx/blob/ea694bf5cbccf34e08f36a8d9365d9011b72aeb4/onnx/optimizer/passes/eliminate_nop_dropout.h#L31 all outputs of the Dropout layer are replaced with inputs. However the 2nd output of that layer is mask which shall contain the mask. In the NoOp case this is all 1s and NOT the input

From onnx/onnx#1672
@daquexian
Copy link
Member

Thanks for your issue! I think you are right. I'll fix it soon

@daquexian daquexian added the bug Something isn't working label Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Flamefire @daquexian