Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Cleaning up Spring property configs #134

Open
aweigold opened this issue Jul 17, 2019 · 1 comment
Open

Discussion: Cleaning up Spring property configs #134

aweigold opened this issue Jul 17, 2019 · 1 comment
Assignees

Comments

@aweigold
Copy link
Contributor

aweigold commented Jul 17, 2019

The current repo is very narrowly focused on a single avenue of support by Spring for configuration properties (problems manifest like the discussion here: #132).

There is some expanded documentation available here: https://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-external-config.html

Furthermore, a consumer of this library may wish to make usage of centralized configuration, such as that provided by Spring Cloud config: https://cloud.spring.io/spring-cloud-config/2.1.x/single/spring-cloud-config.html

Proposal would be to:

  • Expand documentation on configuration.
  • Clean up configuration properties specific for ontio and place them under a common prefix ontio.
  • Ensuring all variables, where possible, have defaults in base properties, that are not provided only by profiles.
  • Evaluate all usages of configuration properties and ensure that they are used in a way that allows them to be changed by Spring Cloud at runtime.

I could definitely help with this, however there would be breaking changes with existing property configurations with the proposed prefix, which should be noted.

@NashMiao NashMiao self-assigned this Jul 18, 2019
@NashMiao
Copy link
Contributor

Thanks for your help. I fully agree with your, I also think current configuration needs to be clean up. Would you mind to help me to refactor it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants