check duplicated key in verify header (#1382)

ontio · Dec 30, 2021 · 61d6547 · 61d6547
1 parent 94bb19f
commit 61d6547
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/core/store/ledgerstore/ledger_store.go b/core/store/ledgerstore/ledger_store.go
@@ -491,15 +491,17 @@ func (this *LedgerStoreImp) verifyHeader(header *types.Header) error {
 		if len(header.Bookkeepers) < m {
 			return fmt.Errorf("header Bookkeepers %d more than 6/7 len vbftPeerInfo%d", len(header.Bookkeepers), len(vbftPeerInfo))
 		}
+		usedPubKey := make(map[string]bool)
 		for _, bookkeeper := range header.Bookkeepers {
 			pubkey := vconfig.PubkeyID(bookkeeper)
 			_, present := vbftPeerInfo[pubkey]
-			if !present {
+			if !present || usedPubKey[pubkey] {
 				val, _ := json.Marshal(vbftPeerInfo)
 				log.Errorf("verify header error: invalid pubkey :%v, height:%d, current vbftPeerInfo :%s",
 					pubkey, header.Height, string(val))
 				return fmt.Errorf("verify header error: invalid pubkey : %v", pubkey)
 			}
+			usedPubKey[pubkey] = true
 		}
 		hash := header.Hash()
 		err = signature.VerifyMultiSignature(hash[:], header.Bookkeepers, m, header.SigData)