Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Return search results as an object instead of a hash #21

Merged

Conversation

Bilelkihal
Copy link
Collaborator

PR Description

Return search results as an object instead of a hash to keep backward compatible after adding federation.

@syphax-bouazzouni syphax-bouazzouni self-requested a review October 25, 2024 05:33
Copy link

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code approved but the tests are failing and taking weirdly too much time, it was only 2 minutes before now they are 20 min.
image

@syphax-bouazzouni
Copy link

code approved but the tests are failing and taking weirdly too much time, it was only 2 minutes before now they are 20 min. image

I didn't figure out why if used BiodivPortal in the tests the test timeouts, using the dev server fixed the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants