Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Remove hardcoded TEST_GROUPS #773

Closed
FedericoCeratto opened this issue Nov 20, 2023 · 1 comment
Closed

API: Remove hardcoded TEST_GROUPS #773

FedericoCeratto opened this issue Nov 20, 2023 · 1 comment
Assignees
@hellais
Labels
wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case)

Comments

@FedericoCeratto
Copy link
Contributor

test_groups is now in a database table. Remove it from https://github.com/ooni/backend/blob/master/api/ooniapi/models.py and update private.py accordingly.
@hellais hellais self-assigned this Mar 6, 2024
@hellais hellais closed this as completed Mar 15, 2024
@hellais
Copy link
Member

hellais commented Mar 15, 2024

test_groups should not be a database table, but should rather be a common module in the ooniapi services setup. This should be addressed as part of: #807

@hellais hellais added the wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case) label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hellais hellais

Labels
wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FedericoCeratto @hellais