Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

honor the client Logger #24

Open
ainghazal opened this issue Aug 30, 2022 · 1 comment
Open

honor the client Logger #24

ainghazal opened this issue Aug 30, 2022 · 1 comment

Comments

@ainghazal
Copy link
Collaborator

ainghazal commented Aug 30, 2022

in minivpn/vpn, at some point I made an attempt at passing a logger from options to the client.
that attempt is not completed (and Options should perhaps not be polluted with this); the interface is there, but right now all the logs are using the default (global) logger.

should either normalize use of client's logger (which means passing it down the hierarchy)... or perhaps setup the global logger at the beginning of Start() based on any non-nil implementation in Client.

@ainghazal
Copy link
Collaborator Author

related to this: extras could ship a convenience nullLogger implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant