Skip to content

Commit bd6f222

Browse files
authored
chore: update part of the work api ReadOnly comment to clarify it's still possible to use status feedback (#338)
Signed-off-by: Mike Ng <[email protected]>
1 parent 05dd01d commit bd6f222

5 files changed

+9
-5
lines changed

addon/v1alpha1/0000_03_addon.open-cluster-management.io_addontemplates.crd.yaml

+2-1
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,8 @@ spec:
276276
ServerSideApply type means to update resource using server side apply with work-controller as the field manager.
277277
If there is conflict, the related Applied condition of manifest will be in the status of False with the
278278
reason of ApplyConflict.
279-
ReadOnly type means the agent will only check the existence of the resource based on its metadata.
279+
ReadOnly type means the agent will only check the existence of the resource based on its metadata,
280+
statusFeedBackRules can still be used to get feedbackResults.
280281
enum:
281282
- Update
282283
- CreateOnly

work/v1/0000_00_work.open-cluster-management.io_manifestworks.crd.yaml

+2-1
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,8 @@ spec:
259259
ServerSideApply type means to update resource using server side apply with work-controller as the field manager.
260260
If there is conflict, the related Applied condition of manifest will be in the status of False with the
261261
reason of ApplyConflict.
262-
ReadOnly type means the agent will only check the existence of the resource based on its metadata.
262+
ReadOnly type means the agent will only check the existence of the resource based on its metadata,
263+
statusFeedBackRules can still be used to get feedbackResults.
263264
enum:
264265
- Update
265266
- CreateOnly

work/v1/types.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,8 @@ type UpdateStrategy struct {
162162
// ServerSideApply type means to update resource using server side apply with work-controller as the field manager.
163163
// If there is conflict, the related Applied condition of manifest will be in the status of False with the
164164
// reason of ApplyConflict.
165-
// ReadOnly type means the agent will only check the existence of the resource based on its metadata.
165+
// ReadOnly type means the agent will only check the existence of the resource based on its metadata,
166+
// statusFeedBackRules can still be used to get feedbackResults.
166167
// +kubebuilder:default=Update
167168
// +kubebuilder:validation:Enum=Update;CreateOnly;ServerSideApply;ReadOnly
168169
// +kubebuilder:validation:Required

work/v1/zz_generated.swagger_doc_generated.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

work/v1alpha1/0000_00_work.open-cluster-management.io_manifestworkreplicasets.crd.yaml

+2-1
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,8 @@ spec:
283283
ServerSideApply type means to update resource using server side apply with work-controller as the field manager.
284284
If there is conflict, the related Applied condition of manifest will be in the status of False with the
285285
reason of ApplyConflict.
286-
ReadOnly type means the agent will only check the existence of the resource based on its metadata.
286+
ReadOnly type means the agent will only check the existence of the resource based on its metadata,
287+
statusFeedBackRules can still be used to get feedbackResults.
287288
enum:
288289
- Update
289290
- CreateOnly

0 commit comments

Comments
 (0)