Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize file content in deploy-kubernetes-resources #378

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Optimize file content in deploy-kubernetes-resources #378

merged 1 commit into from
Aug 24, 2023

Conversation

ydFu
Copy link
Member

@ydFu ydFu commented Aug 18, 2023

  1. Adding syntax highlighting enhances readability for the readers.
  2. Rectifying the representation of command-line inputs for consistency throughout the article.
  3. Adjusting proper indentation for improved formatting.

@openshift-ci openshift-ci bot requested review from dhaiducek and mikeshng August 18, 2023 08:35
@ydFu
Copy link
Member Author

ydFu commented Aug 24, 2023

/assign @mikeshng

dhaiducek
dhaiducek approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the update, @ydFu!

@openshift-ci openshift-ci bot added the lgtm label Aug 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, ydFu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 72f762c into open-cluster-management-io:main Aug 24, 2023
@ydFu ydFu deleted the update-deploy-kubernetes-resources branch August 25, 2023 01:25
@ydFu ydFu mentioned this pull request Aug 31, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaiducek dhaiducek dhaiducek approved these changes

@mikeshng mikeshng Awaiting requested review from mikeshng

Assignees

@dhaiducek dhaiducek

@mikeshng mikeshng

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ydFu @dhaiducek @openshift-merge-robot @mikeshng