Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rollout strategy and update mwrSet #400

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

serngawy
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot requested review from dhaiducek and mikeshng November 14, 2023 17:04
@serngawy
Copy link
Member Author

/assign @haoqing0110 @qiujian16

@haoqing0110
Copy link
Member

LGTM. I will add more addon + rollout API examples in addon page.

@aii-nozomu-oki
Copy link
Contributor

This is exactly what I wanted to know and I appreciate the attempt to document it.
By the way, what does "the successful state" mean?
Is it AppliedManifestComplete: true, ResourceAvailable: true, or something else?

@serngawy
Copy link
Member Author

serngawy commented Nov 15, 2023

This is exactly what I wanted to know and I appreciate the attempt to document it. By the way, what does "the successful state" mean? Is it AppliedManifestComplete: true, ResourceAvailable: true, or something else?

mentioned "the successful state" in placement as successful state cause the definition is different from one API to another; like for manifestwork successful mean resource is available, for other APIs is something else.

Signed-off-by: melserngawy <[email protected]>
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 17, 2023
Copy link
Contributor

openshift-ci bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, serngawy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e64ed85 into open-cluster-management-io:main Nov 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants