-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rollout strategy and update mwrSet #400
Add rollout strategy and update mwrSet #400
Conversation
/assign @haoqing0110 @qiujian16 |
LGTM. I will add more addon + rollout API examples in addon page. |
This is exactly what I wanted to know and I appreciate the attempt to document it. |
After examining the code, it seems to be determined from It might be a good idea to briefly mention that in the documentation. |
mentioned "the successful state" in placement as successful state cause the definition is different from one API to another; like for manifestwork successful mean resource is available, for other APIs is something else. |
okay will add more info for that in the manifestWorkReplicaSet |
Signed-off-by: melserngawy <[email protected]>
Signed-off-by: melserngawy <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, serngawy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e64ed85
into
open-cluster-management-io:main
No description provided.