feat: persist discussion alert dismissal #59
Merged
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CefBoud
force-pushed
the
cef/BB-9079/save-discussion-alert-dismissal
branch
from
723a176 to
b9113a5
Compare
CefBoud
force-pushed
the
cef/BB-9079/save-discussion-alert-dismissal
branch
3 times, most recently
from
0aebc09 to
b036f93
Compare
|
@CefBoud hey, I can't find the line |
|
@DanielVZ96 apologies. I forgot to add the link. Here it is. |
CefBoud
force-pushed
the
cef/BB-9079/save-discussion-alert-dismissal
branch
from
b036f93 to
04bdc64
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## asu-moe/redwood-css #59 +/- ##
====================================================
Coverage 92.43% 92.44%
====================================================
Files 708 708
Lines 12539 12541 +2
Branches 2690 2726 +36
====================================================
+ Hits 11591 11594 +3
+ Misses 913 912 -1
Partials 35 35 ☔ View full report in Codecov by Sentry. |
DanielVZ96
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
👍
- I tested instructions above
- I read through the code
- I checked for accessibility issues
- Includes documentation
- Added to the Code Drift project board (for backports)
Coverage went down, so I'd prefer for you to add a test for this... but I'll leave it up to you
CefBoud
force-pushed
the
cef/BB-9079/save-discussion-alert-dismissal
branch
2 times, most recently
from
fdb9e17 to
d900386
Compare
CefBoud
force-pushed
the
cef/BB-9079/save-discussion-alert-dismissal
branch
from
d900386 to
4584d6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The alert used to inform about the usage of an upgraded version of discussion forum still shows on refresh after being dismissed. The goal of this PR is correct that and save the dismissal per course.
Testing instruction
npm insalltutor mounts add your/path/to/frontend-app-course-authoringtutor dev launchnpm installref
BB-9079