Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Advanced Settings" settings item [BB-9081] (#1252) #67

Merged

Conversation

0x29a
Copy link
Member

@0x29a 0x29a commented Sep 13, 2024

  • refactor: convert header utils to hooks

  • feat: hide advanced settings button if a user doesn't have access

(cherry picked from commit 45c68d6)

* refactor: convert header utils to hooks

* feat: hide advanced settings button if a user doesn't have access

(cherry picked from commit 45c68d6)
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.56%. Comparing base (acbd7fa) to head (147effd).
Report is 4 commits behind head on asu-moe/redwood-css.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           asu-moe/redwood-css      #67      +/-   ##
=======================================================
+ Coverage                92.54%   92.56%   +0.02%     
=======================================================
  Files                      706      706              
  Lines                    12515    12542      +27     
  Branches                  2728     2744      +16     
=======================================================
+ Hits                     11582    11610      +28     
+ Misses                     898      897       -1     
  Partials                    35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@xitij2000 xitij2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: tested on sandbox
  • I read through the code

@0x29a 0x29a merged commit a3f8dba into asu-moe/redwood-css Sep 19, 2024
4 of 5 checks passed
@0x29a 0x29a deleted the 0x29a/BB-9081/hide-advanced-settings-backport branch September 19, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants