You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As of right now, the OpenFeature .NET SDK doesn't properly handle returning error resolutions; when a provider returns an erroneous evaluation by setting the errotType, the error hooks do not run, and for many purposes, the evaluation appears to have succeeded.
In other SDKs, we've made changes to check the resolution details and if the errorType is set (or anything but ErrorType.None in the case of this SDK) we then behave similarly to if something was thrown. We don't currently do this in the .NET SDK. This isn't ideal, since exceptions are generally bad for control flow and are expensive.
To resolve this:
after evaluation, check if the errorType is not ErrorType.None, and if not, behave as if the provider threw an Exception by:
running the error hooks
setting the error message (the description of the ErrorType would be fine)
NOT running the after hooks
add associated tests
The text was updated successfully, but these errors were encountered:
Requirements
As of right now, the OpenFeature .NET SDK doesn't properly handle returning error resolutions; when a provider returns an erroneous evaluation by setting the errotType, the
error hooks
do not run, and for many purposes, the evaluation appears to have succeeded.In other SDKs, we've made changes to check the resolution details and if the errorType is set (or anything but
ErrorType.None
in the case of this SDK) we then behave similarly to if something was thrown. We don't currently do this in the .NET SDK. This isn't ideal, since exceptions are generally bad for control flow and are expensive.To resolve this:
errorType
is notErrorType.None
, and if not, behave as if the provider threw an Exception by:ErrorType
would be fine)The text was updated successfully, but these errors were encountered: