Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/of 374 dapp is not approved to spend operator credit balance by #142

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

george-openformat
Copy link
Contributor

@george-openformat george-openformat commented Oct 9, 2024

Improves usability by automatically granting the dapp that deploys a credit token (ERC20Base) a maximum spend allowance for the operators balance.

Also adds a version to ERC20 Base contract

Once deployed will work for all new ERC20Base contracts created. Old ones will still require an approval transaction.

Related Issue/Bounty

OF-374

Type of Change

  • New feature (non-breaking change which adds functionality)

Copy link

changeset-bot bot commented Oct 9, 2024

⚠️ No Changeset found

Latest commit: b2ebb5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@george-openformat george-openformat force-pushed the feature/of-374-dapp-is-not-approved-to-spend-operator-credit-balance-by branch from b062f46 to b2ebb5b Compare October 9, 2024 12:20
Copy link
Contributor

@nup9151f nup9151f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants