From 094a19a920be3e3c44518ebdb924fef1bfdb0df0 Mon Sep 17 00:00:00 2001
From: robinvandermolen <robin@maykinmedia.nl>
Date: Tue, 8 Oct 2024 14:23:10 +0200
Subject: [PATCH] :lipstick: [open-formulieren/open-forms#4636] Fixed custom
 table styling

---
 src/components/builder/i18n.tsx        | 15 +++++++++------
 src/components/builder/table.scss      | 10 ++++++++++
 src/components/builder/values/i18n.tsx | 13 +++++++++----
 3 files changed, 28 insertions(+), 10 deletions(-)

diff --git a/src/components/builder/i18n.tsx b/src/components/builder/i18n.tsx
index a6c3022..50b10d8 100644
--- a/src/components/builder/i18n.tsx
+++ b/src/components/builder/i18n.tsx
@@ -57,7 +57,10 @@ export function ComponentTranslations<S extends AnyComponentSchema>({
       <table className="table table-bordered offb-table">
         <thead>
           <tr className="offb-i18n-header">
-            <td colSpan={2} className="offb-i18n-header__label">
+            <td
+              colSpan={2}
+              className="offb-i18n-header__label offb-table__col offb-table__col--width-50"
+            >
               <ComponentLabel
                 label={
                   <FormattedMessage
@@ -71,7 +74,7 @@ export function ComponentTranslations<S extends AnyComponentSchema>({
                 })}
               />
             </td>
-            <td className="offb-i18n-header__tab-container">
+            <td className="offb-i18n-header__tab-container offb-table__col offb-table__col--width-50">
               <ul className={`nav nav-tabs offb-i18n-header__tabs`}>
                 {supportedLanguageCodes.map(code => (
                   <li key={code} className={clsx('nav-item', {active: code === activeLanguage})}>
@@ -93,19 +96,19 @@ export function ComponentTranslations<S extends AnyComponentSchema>({
           </tr>
 
           <tr>
-            <th style={{width: '20%'}}>
+            <th className="offb-table__col offb-table__col--width-25">
               <FormattedMessage
                 description="Translations: location column header"
                 defaultMessage="Location"
               />
             </th>
-            <th style={{width: '35%'}}>
+            <th className="offb-table__col offb-table__col--width-25">
               <FormattedMessage
                 description="Translations: property column header"
                 defaultMessage="Value"
               />
             </th>
-            <th style={{borderTop: 'none'}}>
+            <th className="offb-table__col offb-table__col--width-50">
               <FormattedMessage
                 description="Translations: translation column header"
                 defaultMessage="Translations"
@@ -125,7 +128,7 @@ export function ComponentTranslations<S extends AnyComponentSchema>({
               <td>
                 <div
                   aria-describedby={`component-translation-property-${property}`}
-                  className="offb-table__content--allow-break"
+                  className="offb-table__content offb-table__content--allow-break"
                 >
                   {(values?.[property] || '-') as string}
                 </div>
diff --git a/src/components/builder/table.scss b/src/components/builder/table.scss
index d796162..1ae04bd 100644
--- a/src/components/builder/table.scss
+++ b/src/components/builder/table.scss
@@ -1,6 +1,7 @@
 .offb-table {
   // Ensures that the column widths are respected
   table-layout: fixed;
+  width: 100%;
 
   &__content {
     &--allow-break {
@@ -8,4 +9,13 @@
       hyphens: auto;
     }
   }
+
+  &__col {
+    &--width-25 {
+      width: 25%;
+    }
+    &--width-50 {
+      width: 50%;
+    }
+  }
 }
diff --git a/src/components/builder/values/i18n.tsx b/src/components/builder/values/i18n.tsx
index d1cb52e..9a0af86 100644
--- a/src/components/builder/values/i18n.tsx
+++ b/src/components/builder/values/i18n.tsx
@@ -46,14 +46,17 @@ export function ValuesTranslations<S>({name, withOptionDescription}: ValuesTrans
           <>
             <tr key={`option-${index}`}>
               <td>
-                <span id={`option-${index}-label`} className="offb-table__content--allow-break">
+                <span
+                  id={`option-${index}-label`}
+                  className="offb-table__content offb-table__content--allow-break"
+                >
                   {label}
                 </span>
               </td>
               <td>
                 <div
                   aria-describedby={`option-${index}-label`}
-                  className="offb-table__content--allow-break"
+                  className="offb-table__content offb-table__content--allow-break"
                 >
                   {value || '-'}
                 </div>
@@ -94,7 +97,9 @@ export function ValuesTranslations<S>({name, withOptionDescription}: ValuesTrans
                     defaultMessage="Option description (<option></option>)"
                     values={{
                       option: () => (
-                        <code className="offb-table__content--allow-break">{value || '-'}</code>
+                        <code className="offb-table__content offb-table__content--allow-break">
+                          {value || '-'}
+                        </code>
                       ),
                     }}
                   />
@@ -104,7 +109,7 @@ export function ValuesTranslations<S>({name, withOptionDescription}: ValuesTrans
               <td>
                 <div
                   aria-describedby={`option-${index}-label`}
-                  className="offb-table__content--allow-break"
+                  className="offb-table__content offb-table__content--allow-break"
                 >
                   {description || '-'}
                 </div>