Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI configuration #31

Closed
2 tasks done
svenvandescheur opened this issue May 1, 2023 · 1 comment · Fixed by #42
Closed
2 tasks done

Add CI configuration #31

svenvandescheur opened this issue May 1, 2023 · 1 comment · Fixed by #42
Assignees
@sergei-maertens

Comments

@svenvandescheur
Copy link
Collaborator

svenvandescheur commented May 1, 2023 •
edited by sergei-maertens
Loading

  • Add storybook test runner
  • Configure CI to run the tests/stories for PRs/pushes

Copy the config from open-formulieren/formio-builder for this
@svenvandescheur svenvandescheur self-assigned this May 1, 2023
@svenvandescheur svenvandescheur moved this from Todo to In Progress in Development May 10, 2023
svenvandescheur added a commit that referenced this issue May 10, 2023
@svenvandescheur
👷 #31 - Add storybook tests to ci.
9553398
svenvandescheur added a commit that referenced this issue May 10, 2023
@svenvandescheur
📌 #31 - Update yarn.lock.
3087ed8
@svenvandescheur svenvandescheur mentioned this issue May 10, 2023
Closed
svenvandescheur added a commit that referenced this issue May 10, 2023
@svenvandescheur
👷 #31 - Add Storybook tests to ci.
82da986
svenvandescheur added a commit that referenced this issue May 10, 2023
@svenvandescheur
📌 #31 - Add yarn.lock.
bcc1b11
svenvandescheur added a commit that referenced this issue May 10, 2023
@svenvandescheur
👷 #31 - Add Storybook tests to ci.
52dcdc7
svenvandescheur added a commit that referenced this issue May 10, 2023
@svenvandescheur
📌 #31 - Add yarn.lock.
0242832
svenvandescheur added a commit that referenced this issue May 10, 2023
@svenvandescheur
👷 #31 - Add Storybook tests to ci.
e5ab434
svenvandescheur added a commit that referenced this issue May 10, 2023
@svenvandescheur
📌 #31 - Add yarn.lock.
5eb8e9b
@svenvandescheur svenvandescheur mentioned this issue May 10, 2023
Merged
@svenvandescheur svenvandescheur moved this from In Progress to Implemented in Development May 10, 2023
@sergei-maertens sergei-maertens mentioned this issue May 10, 2023
Open
@sergei-maertens
Copy link
Member

While reviewing the PR I noticed there are more improvements, see #44. This should probably just all go in a single PR.

@sergei-maertens sergei-maertens moved this from Implemented to In Progress in Development May 11, 2023
sergei-maertens added a commit that referenced this issue May 11, 2023
@sergei-maertens
➕ [#31] -- add storybook test runner dev dependency
bc59b81
sergei-maertens added a commit that referenced this issue May 11, 2023
@sergei-maertens
🔨 [#31] -- add storybook tests to test commands
8a9949f
sergei-maertens added a commit that referenced this issue May 11, 2023
@sergei-maertens
🔧 [#31] -- fix eslint config for react-jsx runtime
c4d96af 
We use react-jsx runtime via the typescript config, which means that
React does not need to be in scope (typescript injects the necessary
imports during compilation).
sergei-maertens added a commit that referenced this issue May 11, 2023
@sergei-maertens
👷 [#31] -- refactor CI workflows
f29ee4b 
Merged the sb.yml and ci.yml workflow so that they can leverage the
workflow artifacts in different jobs to avoid double work.
sergei-maertens added a commit that referenced this issue May 11, 2023
@sergei-maertens
👷 [#31] -- add running storybook tests to CI pipeline
0c92d41
@sergei-maertens sergei-maertens moved this from In Progress to Implemented in Development May 11, 2023
sergei-maertens added a commit that referenced this issue May 11, 2023
@sergei-maertens
👷 [#31] -- refactor CI workflows
5b653b3 
Merged the sb.yml and ci.yml workflow so that they can leverage the
workflow artifacts in different jobs to avoid double work.
sergei-maertens added a commit that referenced this issue May 11, 2023
@sergei-maertens
👷 [#31] -- add running storybook tests to CI pipeline
a5591e0
sergei-maertens added a commit that referenced this issue May 11, 2023
@sergei-maertens
👷 [#31] -- add running storybook tests to CI pipeline
a4300f0
sergei-maertens added a commit that referenced this issue May 11, 2023
@sergei-maertens
Merge pull request #42 from open-formulieren/feature/#31-ci
bd04ec0 
Feature/#31 ci
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergei-maertens sergei-maertens

Labels
None yet
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/#31 ci open-formulieren/formio-renderer
Feature/#31 ci open-formulieren/formio-renderer
2 participants
@sergei-maertens @svenvandescheur