[#8] Update API endpoint for forms #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
requested changes
Jun 26, 2024
tests/test_client.py
Outdated
|
|
||
| result = self.client.get_form("myform") | ||
| self.assertDictEqual(result, {}) | ||
|
|
||
| def test_get_form_with_error(self, m): | ||
| m.get(f"{self.api_root}forms/myform", status_code=401) | ||
| m.get(f"{self.api_root}public/forms/myform", status_code=401) |
There was a problem hiding this comment.
this endpoint does not exist
I recommend using VCR.py for these tests with a docker-compose setup to bring up a real instance :)
There was a problem hiding this comment.
I've looked into VCR and agree (haven't thought about docker-compose though). Will do this in a separate PR.
pi-sigma
force-pushed
the
issue/8-api-endpoint
branch
from
539b917 to
cffb558
Compare
pi-sigma
force-pushed
the
issue/8-api-endpoint
branch
from
cffb558 to
81e0207
Compare
sergei-maertens
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
We only support OpenForms >= 2.6, where the new endpoint was introduced (the only supported version that does not have the new endpoint is 2.5).