Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK: session expiry should be its own route #645

Closed
sergei-maertens opened this issue Feb 14, 2024 · 0 comments · Fixed by #649
Closed

SDK: session expiry should be its own route #645

sergei-maertens opened this issue Feb 14, 2024 · 0 comments · Fixed by #649
Assignees
@nikkiysendoorn1

Comments

@sergei-maertens
Copy link
Member

Now we have clunky state management and container routes that perform side effects (such as creating a new submission).

Instead, when the user session expires, we should (client-side) redirect to a dedicated page showing the message, and the side effect should be that any session data and state (sessionStorage and the like) are cleared.
@sergei-maertens sergei-maertens self-assigned this Feb 14, 2024
@sergei-maertens sergei-maertens converted this from a draft issue Feb 14, 2024
@sergei-maertens sergei-maertens moved this from Todo to In Progress in Development Feb 19, 2024
nikkiysendoorn1 added a commit that referenced this issue Feb 19, 2024
@nikkiysendoorn1
🚧 [#645] Add route for session expired & add a new component & clean …
d6979fe 
…up some code
@nikkiysendoorn1 nikkiysendoorn1 linked a pull request Feb 20, 2024 that will close this issue
Move session expiry page to own route #649
Merged
@sergei-maertens sergei-maertens moved this from In Progress to Implemented in Development Feb 21, 2024
@sergei-maertens sergei-maertens mentioned this issue Feb 21, 2024
Merged
@nikkiysendoorn1 nikkiysendoorn1 moved this from Implemented to In Progress in Development Feb 21, 2024
nikkiysendoorn1 added a commit that referenced this issue Feb 21, 2024
@nikkiysendoorn1
✅ [#645] add storybook for SessionExpired
a5ba193
nikkiysendoorn1 added a commit that referenced this issue Feb 21, 2024
@nikkiysendoorn1
🚚 [#645] change the SessionTrackerModal path and name
b4c8264
@nikkiysendoorn1 nikkiysendoorn1 moved this from In Progress to Implemented in Development Feb 21, 2024
@nikkiysendoorn1 nikkiysendoorn1 moved this from Implemented to In Progress in Development Feb 26, 2024
nikkiysendoorn1 added a commit that referenced this issue Feb 28, 2024
@nikkiysendoorn1
✅ [#645] update storybook for Session Expired
30cdc25
nikkiysendoorn1 added a commit that referenced this issue Feb 28, 2024
@nikkiysendoorn1
🎨 [#645] remove extension for import
4511c96
nikkiysendoorn1 added a commit that referenced this issue Feb 28, 2024
@nikkiysendoorn1
🎨 [#645] optimize code for useSessionTimeout
4854ede
@nikkiysendoorn1 nikkiysendoorn1 moved this from In Progress to Implemented in Development Feb 28, 2024
nikkiysendoorn1 added a commit that referenced this issue Mar 4, 2024
@nikkiysendoorn1
🎨 [#645] remove noNavigate and format some imports
72916aa
nikkiysendoorn1 added a commit that referenced this issue Mar 5, 2024
@nikkiysendoorn1
🐛 [#645] remove check on wrapper
377d31a
sergei-maertens added a commit that referenced this issue Mar 12, 2024
@sergei-maertens
🚨 [#645] Remove unused code/imports
b088c1c
sergei-maertens added a commit that referenced this issue Mar 12, 2024
@sergei-maertens
🐛 [#645] Fix infinite redirect loop in appointments, causing jest to …
2848389 
…go OOM
sergei-maertens pushed a commit that referenced this issue Mar 12, 2024
@nikkiysendoorn1 @sergei-maertens
✨ [#645] Implement standalone route/component for expired session
9a51320 
The component is responsible for cleanup of local/session storage and
resetting the session expiry if not done so yet.

Because the component is mounted on its own route, it will cause all
other components that trigger the redirect to be unmounted and their
state will automatically be reset too, leaving only the persistent
storages like session/local storage to be cleaned up.
sergei-maertens pushed a commit that referenced this issue Mar 12, 2024
@nikkiysendoorn1 @sergei-maertens
♻️ [#645] Refactor useSessionTimeout hook and expiry modal
9020f06 
The expiry hook now tracks when the session will expire and performs
a redirect when the session is effectively expired, which in turn
triggers the necessary cleanup effects.

The SessionTrackerModal is a rename of the RequireSession component,
which now only has to keep track of imminent expiry of the session
so that the end-user receives a warning and can opt to extend the
session.

Usage of these components is cleaned up, which in general simplifies
state management a bit.
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikkiysendoorn1 nikkiysendoorn1

Labels
None yet
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move session expiry page to own route open-formulieren/open-forms-sdk
2 participants
@sergei-maertens @nikkiysendoorn1