From 9819ce6f9e2d60cf778c3db5b2f9edacf3967262 Mon Sep 17 00:00:00 2001
From: vasileios <zigras00@gmail.com>
Date: Wed, 17 Jul 2024 15:40:45 +0200
Subject: [PATCH] [#4533] Fixed upload submission csv checkbox (onFieldChange
 event) in Objects API

---
 .../registrations/objectsapi/LegacyConfigFields.js     | 10 ++++++----
 .../registrations/objectsapi/ObjectsApiOptionsForm.js  |  2 +-
 .../objectsapi/ObjectsApiOptionsFormFields.js          |  2 +-
 .../registrations/objectsapi/V2ConfigFields.js         | 10 ++++++----
 4 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/src/openforms/js/components/admin/form_design/registrations/objectsapi/LegacyConfigFields.js b/src/openforms/js/components/admin/form_design/registrations/objectsapi/LegacyConfigFields.js
index ba8cd14913..cc9fd05f33 100644
--- a/src/openforms/js/components/admin/form_design/registrations/objectsapi/LegacyConfigFields.js
+++ b/src/openforms/js/components/admin/form_design/registrations/objectsapi/LegacyConfigFields.js
@@ -19,7 +19,7 @@ const LegacyConfigFields = ({index, name, schema, formData, onFieldChange}) => {
     objecttypeVersion = '',
     productaanvraagType = '',
     informatieobjecttypeSubmissionReport = '',
-    uploadSubmissionCsv = '',
+    uploadSubmissionCsv = false,
     informatieobjecttypeSubmissionCsv = '',
     informatieobjecttypeAttachment = '',
     organisatieRsin = '',
@@ -182,8 +182,10 @@ const LegacyConfigFields = ({index, name, schema, formData, onFieldChange}) => {
         <Checkbox
           id="root_uploadSubmissionCsv"
           name="uploadSubmissionCsv"
-          value={uploadSubmissionCsv}
-          onChange={onFieldChange}
+          checked={uploadSubmissionCsv}
+          onChange={e =>
+            onFieldChange({target: {name: 'uploadSubmissionCsv', value: !uploadSubmissionCsv}})
+          }
         />
       </CustomFieldTemplate>
       <CustomFieldTemplate
@@ -319,7 +321,7 @@ LegacyConfigFields.propTypes = {
     objecttypeVersion: PropTypes.string,
     productaanvraagType: PropTypes.string,
     informatieobjecttypeSubmissionReport: PropTypes.string,
-    uploadSubmissionCsv: PropTypes.string,
+    uploadSubmissionCsv: PropTypes.bool,
     informatieobjecttypeSubmissionCsv: PropTypes.string,
     informatieobjecttypeAttachment: PropTypes.string,
     organisatieRsin: PropTypes.string,
diff --git a/src/openforms/js/components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsForm.js b/src/openforms/js/components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsForm.js
index cc5700fa0a..9b97ff25df 100644
--- a/src/openforms/js/components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsForm.js
+++ b/src/openforms/js/components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsForm.js
@@ -30,7 +30,7 @@ ObjectsApiOptionsForm.propTypes = {
     objecttypeVersion: PropTypes.string,
     productaanvraagType: PropTypes.string,
     informatieobjecttypeSubmissionReport: PropTypes.string,
-    uploadSubmissionCsv: PropTypes.string,
+    uploadSubmissionCsv: PropTypes.bool,
     informatieobjecttypeSubmissionCsv: PropTypes.string,
     informatieobjecttypeAttachment: PropTypes.string,
     organisatieRsin: PropTypes.string,
diff --git a/src/openforms/js/components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsFormFields.js b/src/openforms/js/components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsFormFields.js
index f8cefd0d9e..4b217ed486 100644
--- a/src/openforms/js/components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsFormFields.js
+++ b/src/openforms/js/components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsFormFields.js
@@ -135,7 +135,7 @@ ObjectsApiOptionsFormFields.propTypes = {
     objecttypeVersion: PropTypes.string,
     productaanvraagType: PropTypes.string,
     informatieobjecttypeSubmissionReport: PropTypes.string,
-    uploadSubmissionCsv: PropTypes.string,
+    uploadSubmissionCsv: PropTypes.bool,
     informatieobjecttypeSubmissionCsv: PropTypes.string,
     informatieobjecttypeAttachment: PropTypes.string,
     organisatieRsin: PropTypes.string,
diff --git a/src/openforms/js/components/admin/form_design/registrations/objectsapi/V2ConfigFields.js b/src/openforms/js/components/admin/form_design/registrations/objectsapi/V2ConfigFields.js
index fa29d4c6e2..0aa59e35ee 100644
--- a/src/openforms/js/components/admin/form_design/registrations/objectsapi/V2ConfigFields.js
+++ b/src/openforms/js/components/admin/form_design/registrations/objectsapi/V2ConfigFields.js
@@ -23,7 +23,7 @@ const V2ConfigFields = ({index, name, schema, formData, onFieldChange, onChange}
     objecttype = '',
     objecttypeVersion = '',
     informatieobjecttypeSubmissionReport = '',
-    uploadSubmissionCsv = '',
+    uploadSubmissionCsv = false,
     informatieobjecttypeSubmissionCsv = '',
     informatieobjecttypeAttachment = '',
     organisatieRsin = '',
@@ -213,8 +213,10 @@ const V2ConfigFields = ({index, name, schema, formData, onFieldChange, onChange}
         <Checkbox
           id="root_uploadSubmissionCsv"
           name="uploadSubmissionCsv"
-          value={uploadSubmissionCsv}
-          onChange={onFieldChange}
+          checked={uploadSubmissionCsv}
+          onChange={e =>
+            onFieldChange({target: {name: 'uploadSubmissionCsv', value: !uploadSubmissionCsv}})
+          }
         />
       </CustomFieldTemplate>
       <CustomFieldTemplate
@@ -304,7 +306,7 @@ V2ConfigFields.propTypes = {
     objecttype: PropTypes.string,
     objecttypeVersion: PropTypes.string,
     informatieobjecttypeSubmissionReport: PropTypes.string,
-    uploadSubmissionCsv: PropTypes.string,
+    uploadSubmissionCsv: PropTypes.bool,
     informatieobjecttypeSubmissionCsv: PropTypes.string,
     informatieobjecttypeAttachment: PropTypes.string,
     organisatieRsin: PropTypes.string,