Skip to content

Commit

Permalink
🧪 [#3901] Add regression test for blocked registration because of cosign
Browse files Browse the repository at this point in the history
A required but hidden cosign component should not block the submission
registration.
  • Loading branch information
sergei-maertens committed Dec 10, 2024
1 parent 3e7b959 commit 48b6d3b
Showing 1 changed file with 32 additions and 1 deletion.
33 changes: 32 additions & 1 deletion src/openforms/submissions/tests/test_post_submission_event.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
)
from openforms.utils.tests.logging import ensure_logger_level

from ..constants import PostSubmissionEvents
from ..constants import PostSubmissionEvents, RegistrationStatuses
from ..models import SubmissionReport
from ..tasks import on_post_submission_event
from .factories import SubmissionFactory
Expand Down Expand Up @@ -996,6 +996,37 @@ def test_cosign_not_required_but_filled_in_does_not_proceed_with_registration(se
self.assertTrue(submission.confirmation_email_sent)
self.assertEqual(submission.auth_info.value, "111222333")

@tag("gh-3901", "hlmr-86")
def test_cosign_required_but_hidden_proceeds_with_registration(self):
"""
A conditionally hidden cosign component may not block registration.
"""
submission = SubmissionFactory.from_components(
components_list=[
{
"key": "cosign",
"type": "cosign",
"label": "Cosign component",
"validate": {"required": True},
"hidden": True,
},
],
submitted_data={"cosign": ""},
completed=True,
cosign_complete=False,
form__registration_backend="email",
form__registration_backend_options={"to_emails": ["[email protected]"]},
auth_info__attribute=AuthAttribute.bsn,
auth_info__value="111222333",
language_code="en",
)
assert submission.registration_status == RegistrationStatuses.pending

on_post_submission_event(submission.pk, PostSubmissionEvents.on_completion)

submission.refresh_from_db()
self.assertEqual(submission.registration_status, RegistrationStatuses.success)

@tag("gh-3924")
def test_payment_complete_does_not_set_retry_flag(self):
submission = SubmissionFactory.create(
Expand Down

0 comments on commit 48b6d3b

Please sign in to comment.