🚚 [#4788] Rename several fields on Objects API config model

open-formulieren · Dec 2, 2024 · 5cb5618 · 5cb5618
1 parent 6de6199
commit 5cb5618
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 9 deletions.
diff --git a/docker/setup_configuration/data.yaml b/docker/setup_configuration/data.yaml
@@ -37,7 +37,7 @@ objects_api:
     identifier: config-1
     objects_service_identifier: objecten-test
     objecttypes_service_identifier: objecttypen-test
-    drc_service_identifier: documenten-test
+    documenten_service_identifier: documenten-test
     catalogi_service_identifier: catalogi-test
     catalogue_domain: TEST
     catalogue_rsin: "000000000"
@@ -49,7 +49,7 @@ objects_api:
     identifier: config-2
     objects_service_identifier: objecten-test
     objecttypes_service_identifier: objecttypen-test
-    drc_service_identifier: documenten-test
+    documenten_service_identifier: documenten-test
     catalogi_service_identifier: catalogi-test
     catalogue_domain: OTHER
     catalogue_rsin: "000000000"

diff --git a/src/openforms/contrib/objects_api/setup_configuration/models.py b/src/openforms/contrib/objects_api/setup_configuration/models.py
@@ -12,7 +12,7 @@ class SingleObjectsAPIGroupConfigModel(ConfigurationModel):
     objecttypes_service_identifier: str = DjangoModelRef(
         ObjectsAPIGroupConfig, "objecttypes_service"
     )
-    drc_service_identifier: str = DjangoModelRef(
+    documenten_service_identifier: str = DjangoModelRef(
         ObjectsAPIGroupConfig, "drc_service", default=""
     )
     catalogi_service_identifier: str = DjangoModelRef(

diff --git a/src/openforms/contrib/objects_api/setup_configuration/steps.py b/src/openforms/contrib/objects_api/setup_configuration/steps.py
@@ -43,8 +43,10 @@ def execute(self, model: ObjectsAPIGroupConfigModel):
                 "iot_submission_csv": config.iot_submission_csv,
                 "iot_attachment": config.iot_attachment,
             }
-            if config.drc_service_identifier:
-                defaults["drc_service"] = get_service(config.drc_service_identifier)
+            if config.documenten_service_identifier:
+                defaults["drc_service"] = get_service(
+                    config.documenten_service_identifier
+                )
             if config.catalogi_service_identifier:
                 defaults["catalogi_service"] = get_service(
                     config.catalogi_service_identifier

diff --git a/...enforms/contrib/objects_api/setup_configuration/tests/files/setup_config_objects_api.yaml b/...enforms/contrib/objects_api/setup_configuration/tests/files/setup_config_objects_api.yaml
@@ -5,7 +5,7 @@ objects_api:
     identifier: config-1
     objects_service_identifier: objecten-test
     objecttypes_service_identifier: objecttypen-test
-    drc_service_identifier: documenten-test
+    documenten_service_identifier: documenten-test
     catalogi_service_identifier: catalogi-test
     catalogue_domain: TEST
     catalogue_rsin: "000000000"
@@ -17,7 +17,7 @@ objects_api:
     identifier: config-2
     objects_service_identifier: objecten-test
     objecttypes_service_identifier: objecttypen-test
-    drc_service_identifier: documenten-test
+    documenten_service_identifier: documenten-test
     catalogi_service_identifier: catalogi-test
     catalogue_domain: OTHER
     catalogue_rsin: "000000000"

diff --git a/...trib/objects_api/setup_configuration/tests/files/setup_config_objects_api_all_fields.yaml b/...trib/objects_api/setup_configuration/tests/files/setup_config_objects_api_all_fields.yaml
@@ -5,7 +5,7 @@ objects_api:
     identifier: config-1
     objects_service_identifier: objecten-test
     objecttypes_service_identifier: objecttypen-test
-    drc_service_identifier: documenten-test
+    documenten_service_identifier: documenten-test
     catalogi_service_identifier: catalogi-test
     catalogue_domain: TEST
     catalogue_rsin: "000000000"

diff --git a/src/openforms/contrib/objects_api/tests/test_migrations.py b/src/openforms/contrib/objects_api/tests/test_migrations.py
@@ -3,7 +3,7 @@
 from openforms.utils.tests.test_migrations import TestMigrations
 
 
-class MigrateFeatureFlagsTests(TestMigrations):
+class AddObjectsAPIGroupIdentifierTests(TestMigrations):
     app = "objects_api"
     migrate_from = "0001_initial"
     migrate_to = "0002_objectsapigroupconfig_identifier"