Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Co-sign data validation serializer is not compatible with co-sign v2 flow. #4308

Open
Tracked by #4791
sergei-maertens opened this issue May 17, 2024 · 1 comment
Open
Tracked by #4791

Co-sign data validation serializer is not compatible with co-sign v2 flow. #4308

sergei-maertens opened this issue May 17, 2024 · 1 comment
Labels
bug Something isn't working topic: cleanup topic: mede-ondertekenen

Comments

@sergei-maertens
Copy link
Member

sergei-maertens commented May 17, 2024 •
edited
Loading

Product versie / Product version

master / stable versions

Omschrijf het probleem / Describe the bug

Discovered in #4305

The serializer used for (model field) validation only supports the legacy co-sign flow:

open-forms/src/openforms/submissions/models/submission.py

Lines 124 to 130 in e780ea7

co_sign_data = models.JSONField(
_("co-sign data"),
blank=True,
default=dict,
validators=[SerializerValidator(CoSignDataSerializer)],
help_text=_("Authentication details of a co-signer."),
)

This highlights that the serializer is outdated, but also that it's not being called to check the input data.

Related information: #3149 has a bullet about moving the co sign data into a proper model rather than using a JSONField. The main problem here is that the shape of data is ambiguous/not clear from looking at the data model. The wrong serializer even describes an incorrect shape of data, which makes developing with this feature harder than it should be.

When we enforce validation on save, about 20 tests fail, per this comment
@sergei-maertens sergei-maertens added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels May 17, 2024
@sergei-maertens sergei-maertens mentioned this issue May 17, 2024
Merged
9 tasks
@joeribekker
Copy link
Contributor

Refinement: Related to #3283

@joeribekker joeribekker mentioned this issue May 27, 2024
Closed
23 tasks
@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label May 27, 2024
@sergei-maertens sergei-maertens mentioned this issue Oct 25, 2024
Open
3 tasks
sergei-maertens added a commit that referenced this issue Dec 5, 2024
@sergei-maertens
🩹 [#4320] Fix crash when rendering PDF again for cosigned submission
2ac376b 
The PDF was including the cosign data/component for version 1 of cosign,
which is not compatible at all with v2 (see #4308), causing crashes.

Generally this doesn't matter since the PDF is generated right after
submission is received and before its cosigned, and we don't usually
need to re-generate it except during development.
sergei-maertens added a commit that referenced this issue Dec 6, 2024
@sergei-maertens
🩹 [#4320] Fix crash when rendering PDF again for cosigned submission
6b7e21a 
The PDF was including the cosign data/component for version 1 of cosign,
which is not compatible at all with v2 (see #4308), causing crashes.

Generally this doesn't matter since the PDF is generated right after
submission is received and before its cosigned, and we don't usually
need to re-generate it except during development.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working topic: cleanup topic: mede-ondertekenen
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joeribekker @sergei-maertens