Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - rethink email digest structure and handle exceptions #4447

Open
vaszig opened this issue Jun 27, 2024 · 0 comments
Open

Refactor - rethink email digest structure and handle exceptions #4447

vaszig opened this issue Jun 27, 2024 · 0 comments

Comments

@vaszig
Copy link
Contributor

vaszig commented Jun 27, 2024

#4413 and #4400 show that the email digest is getting bigger and seems that we repeat some parts in the code for each broken part of OpenForms (failed_emails, invalid_logic_rules etc. ). This needs discussion and we could make it better by refactoring the code.

For example Sergei mentioned that it would be better to loop over all the forms (one query) and do the various checks there instead of getting all the forms for each check individually.

Furthermore, various exceptions may be raised (like the one in issue 4400) and this can cause the crash of the whole email digest. These exceptions should be handled and inform the user about them.

@vaszig vaszig added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Jun 27, 2024
@joeribekker joeribekker added topic: email digest and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants