Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility improvements - Error and help messages #4719

Closed
3 tasks done
Tracked by #4622
robinmolen opened this issue Oct 1, 2024 · 1 comment · Fixed by #4780
Closed
3 tasks done
Tracked by #4622

Accessibility improvements - Error and help messages #4719

robinmolen opened this issue Oct 1, 2024 · 1 comment · Fixed by #4780
Assignees
Labels
enhancement topic: a11y Accessibility issues
Milestone

Comments

@robinmolen
Copy link
Contributor

robinmolen commented Oct 1, 2024

Thema / Theme

Frontend

Omschrijving / Description

This issue is related to #4622

This issue targets the error and help message improvements of the accessibility rapport:

  • 3.3.1
  • 3.3.2
  • 3.3.3

Added value / Toegevoegde waarde

No response

Aanvullende opmerkingen / Additional context

No response

@robinmolen
Copy link
Contributor Author

Regarding 3.3.3: The translation for the 'Invalid postcode' message has been changed, so all regular postcode fields will now show the expected postcode format. For the pre-fill postcode its a bit more complicated...

The pre-fill postcode doesn't use the validate config, it also isn't added to the DB. I expect its because the type is set to 'textfield' (to allow the pre-fill functionality). So the error message, and validation, is pure because of the inputMask. I've added a custom error message for mask errors on this field, so new pre-fill postcode fields will have the correct error message.

We cannot change the default message for mask errors, because this then would cause issues for other fields with mask validation (i.e. bsn)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement topic: a11y Accessibility issues
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant