Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate FormVariable's attribute field into prefill_options #4756

Open
vaszig opened this issue Oct 15, 2024 · 2 comments
Open

Migrate FormVariable's attribute field into prefill_options #4756

vaszig opened this issue Oct 15, 2024 · 2 comments

Comments

@vaszig
Copy link
Contributor

vaszig commented Oct 15, 2024

This can be done after #4620 has been merged (This PR adds the prefill_options field to the model).

The attribute should be part of the prefill_options JSON field and the general/ideal structure should be:

  • prefill_plugin -> determines the shape of prefill_options
  • prefill_options -> stores plugin-specific configuration options (will contain the attribute key for all the other plugins)
  • prefill_identifier_role -> still used to point to which BSN/KVK to grab from the Submission for auth checks etc.
@vaszig vaszig added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Oct 15, 2024
@joeribekker joeribekker added topic: cleanup and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Oct 21, 2024
@joeribekker
Copy link
Contributor

joeribekker commented Oct 21, 2024

Might be backwards incompatible with custom plugins (read: NHR, DH) and streamlines plugin architecture.

@joeribekker
Copy link
Contributor

This is a prelude to moving the prefill config from the component to the variables tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants