Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React select styling issue with large values #4802

Closed
robinmolen opened this issue Oct 30, 2024 · 0 comments · Fixed by #4812
Closed

React select styling issue with large values #4802

robinmolen opened this issue Oct 30, 2024 · 0 comments · Fixed by #4812
Assignees
@robinmolen
Labels
bug Something isn't working
Milestone
Release 3.0

Comments

@robinmolen
Copy link
Contributor

Product versie / Product version

3.0.0-alpha.0

Customer reference

No response

Omschrijf het probleem / Describe the bug

When the ReactSelect has a large value selected, the help icon will be pushed away. I think the element containing the selected value doesn't have a max-width, and just grows outside the ReactSelect element.

Screenshot 2024-10-30 at 12 31 49

Stappen om te reproduceren / Steps to reproduce

No response

Verwacht gedrag / Expected behavior

No response

Screen resolution

None

Device

None

OS

None

Browser

No response
@robinmolen robinmolen added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Oct 30, 2024
@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Nov 4, 2024
@joeribekker joeribekker added this to the Release 3.0 milestone Nov 4, 2024
robinmolen added a commit that referenced this issue Nov 6, 2024
@robinmolen
🐛 [#4802] Prevent react-select from growing beyond its max inline size
a3054de
robinmolen added a commit that referenced this issue Nov 6, 2024
@robinmolen
💄 [#4802] Remove unnessecery html elements from dom
5f02b1e 
The .catalogi-type-option span element is only needed for the dropdown menu, not when it is the selected value. So the element should only be added when it's used in the dropdown menu.
This also solves some styling issues when the content is beyond the max size of the ReactSelect
robinmolen added a commit that referenced this issue Nov 6, 2024
@robinmolen
✅ [#4802] Updated storybook mock data
cd38d52
@robinmolen robinmolen linked a pull request Nov 6, 2024 that will close this issue
Broken react select styling for large values #4812
Merged
9 tasks
@robinmolen robinmolen mentioned this issue Nov 6, 2024
Merged
9 tasks
robinmolen added a commit that referenced this issue Nov 7, 2024
@robinmolen
💄 [#4802] Remove unnessecery html elements from dom
3887e9d 
The .catalogi-type-option span element is only needed for the dropdown menu, not when it is the selected value. So the element should only be added when it's used in the dropdown menu.
This also solves some styling issues when the content is beyond the max size of the ReactSelect
robinmolen added a commit that referenced this issue Nov 7, 2024
@robinmolen
✅ [#4802] Updated storybook mock data
0db34e9
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinmolen robinmolen

Labels
bug Something isn't working
Projects
Development
Archived in project
Milestone
Release 3.0
Development

Successfully merging a pull request may close this issue.

Broken react select styling for large values open-formulieren/open-forms
2 participants
@joeribekker @robinmolen