Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#4788] Add ConfigurationStep for Admin OIDC login #4891

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Dec 9, 2024

Closes #4788

Changes

  • Add ConfigurationStep for Admin OIDC login

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@stevenbal stevenbal changed the title Feature/4788 setup config admin OIDC ✨ [#4788] Add ConfigurationStep for Admin OIDC login Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (dd38e63) to head (bb95503).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4891   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files         757      757           
  Lines       25945    25945           
  Branches     3419     3419           
=======================================
  Hits        25069    25069           
  Misses        613      613           
  Partials      263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal force-pushed the feature/4789-zgw-setup-config branch 2 times, most recently from fd0d626 to df117af Compare December 9, 2024 08:48
@stevenbal stevenbal marked this pull request as draft December 9, 2024 08:51
@stevenbal stevenbal force-pushed the feature/4788-setup-config-admin-oidc branch 2 times, most recently from 1f5f771 to 74d182e Compare December 9, 2024 10:07
@stevenbal stevenbal changed the base branch from feature/4789-zgw-setup-config to master December 9, 2024 10:08
@stevenbal stevenbal marked this pull request as ready for review December 9, 2024 10:08
@stevenbal stevenbal force-pushed the feature/4788-setup-config-admin-oidc branch from 74d182e to ed3d8ff Compare December 9, 2024 15:28
@stevenbal stevenbal force-pushed the feature/4788-setup-config-admin-oidc branch from ed3d8ff to b4431c2 Compare December 9, 2024 15:30
@stevenbal stevenbal force-pushed the feature/4788-setup-config-admin-oidc branch from b4431c2 to bb95503 Compare December 9, 2024 15:42
@sergei-maertens sergei-maertens merged commit 1ba739e into master Dec 9, 2024
34 checks passed
@sergei-maertens sergei-maertens deleted the feature/4788-setup-config-admin-oidc branch December 9, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Admin-OIDC configuration via django-setup-configuration
2 participants