"Fix" prefill copy button #4902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's obsolete now we're using react-select. The react-select component does accurately reflect the state of option selection, even if no value is selected while leaving the select blank is not allowed.
Handling the reset of dependent fields in the ObjectTypeSelect component is too naive - there's no guarantee that the fields must always be reset, for example with the copy-config-from-registration button. Clicking that button updates a bunch of form state at once, and it already manages the dependent fields. So, providing a callback to handle the reset allows us to handle the dependent fields still, while having to option to incorporate extra context.
The toggle is not displayed if there are no backends to copy from, so the UI can be de-cluttered. Additionally, the mechanism/slot for the extra controls has been refactored to be more generic - anything can now be rendered there that may be relevant, and the state is specific to the UI being rendered so that has been removed from the generic parent component. We use the formik status to track form-specific state, through a small hook that normalizes the shape of the status (since it can be anything).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4902 +/- ##
==========================================
- Coverage 96.62% 96.62% -0.01%
==========================================
Files 757 757
Lines 25952 25942 -10
Branches 3420 3417 -3
==========================================
- Hits 25076 25066 -10
Misses 613 613
Partials 263 263 ☔ View full report in Codecov by Sentry. |
vaszig
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4859
Changes
This affects the Objects API registration a bit with a behaviour change, but makes it consistent in the sense that form state is not reset anymore when upstream APIs are not available, for example, making it consistent with the behaviour of the ZGW API's configuration. Previously, the first available item in a dropdown was selected, but this is not needed anymore now that we're using react-select.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shCommit hygiene