[#4832] Fix json schema matcher in Objects API #4938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change has been made because we are not able to know if the type is the correct one when no format is defined in the variable. This is left to the user and we assume that the mapping is valid.
sergei-maertens
approved these changes
Dec 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4938 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 760 760
Lines 25818 25818
Branches 3382 3382
=======================================
Hits 24947 24947
Misses 606 606
Partials 265 265 ☔ View full report in Codecov by Sentry. |
vaszig
deleted the
fix/4832-uri-attributes-cannot-be-selected-in-the-pfdurl-variable
branch
vaszig
added a commit
that referenced
this pull request
Dec 18, 2024
This change has been made because we are not able to know if the type is the correct one when no format is defined in the variable. This is left to the user and we assume that the mapping is valid. Backport-of: #4938
vaszig
added a commit
that referenced
this pull request
Dec 18, 2024
This change has been made because we are not able to know if the type is the correct one when no format is defined in the variable. This is left to the user and we assume that the mapping is valid. Backport-of: #4938
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4832
Changes
This change has been made because we are not able to know if the type is the correct one when no format is defined in the variable. This is left to the user and we assume that the mapping is valid.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene