🐛 [#4579] Ensure triggerFromStep uses the correct current_step #4967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4967 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 760 760
Lines 25838 25838
Branches 3386 3386
=======================================
Hits 24965 24965
Misses 608 608
Partials 265 265 ☔ View full report in Codecov by Sentry. |
stevenbal
force-pushed
the
issue/4579-block-going-to-next-step-bug
branch
from
5bbd7ea to
b837307
Compare
stevenbal
added
the
needs-backport
previously the current step was inferred by looking at the last completed step and considering the step after that the current step. This does not work however if you complete a step and go back to the previous step, so instead we explicitly pass the current form step via the serializer context
stevenbal
force-pushed
the
issue/4579-block-going-to-next-step-bug
branch
from
51886a3 to
e7c4ef3
Compare
stevenbal
commented
Dec 24, 2024
| @@ -198,7 +200,7 @@ def check_submission_logic( | |||
| if not submission_state.form_steps: | |||
| return | |||
|
|
|||
| rules = get_rules_to_evaluate(submission) | |||
| rules = get_rules_to_evaluate(submission, current_step) | |||
There was a problem hiding this comment.
I was surprised (and suspicious) about this fix, is there a reason why previously the current_step was inferred for this flow, instead of explicitly passed to get_rules_to_evaluate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously the current step was inferred by looking at the last completed step and considering the step after that the current step. This does not work however if you complete a step and go back to the previous step, so instead we explicitly pass the current form step via the serializer context
Closes #4579
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene