Dynamic email registration recipients using variables #4971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmolen
force-pushed
the
feature/4650-set-submission-email-address-using-url-parameters
branch
from
82c9584 to
472a4fd
Compare
|
There are two tasks that still have to be done:
|
Either the `to_emails` or the `to_email_from_variable` fields should used when registering the email backend plugin. When a variable is selected, the resulting email address will be used for mailings. When the variable doesn't contain an email address, the `to_emails` will be used as fallback.
The variable chosen in the email registration (`to_email_from_variable`) will now actually be used for the mailing. `to_emails` is used as fallback, in case that the variable doesn't return a valid email address. The variable will also be used for the payment status update mailing. If `payment_emails` is defined, these will be used as recipients. Otherwise it will use `to_email_from_variable`, and as a last resort the `to_emails`
robinmolen
force-pushed
the
feature/4650-set-submission-email-address-using-url-parameters
branch
from
472a4fd to
575b635
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4971 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 760 760
Lines 25838 25861 +23
Branches 3386 3391 +5
=======================================
+ Hits 24965 24988 +23
Misses 608 608
Partials 265 265 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4650
Changes
The email registration plugin now allows setting the recipient using form variables. This can be combined with the prefill to dynamically set the recipients of a form.
With this, either the emails field (internally known as
to_emails) or the email variable field has to be filled. When both are used, the mailing will favor the variable. If for some reason the variable cannot be used for the mailing (i.e. when the variable doesn't result into a valid email address), then the general emails configuration (to_emails) will be used.The variable can also be used for the payment status update mailings. For the payment status mailing the payment status email addresses will be used. If these aren't defined, then the variable is used and as last resort the general emails configuration will be used.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene