Implement type definition for file upload component #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly describes the base schema and how a single file upload looks like, i.e. what data is chucked over the wire when submitting the form.
sergei-maertens
force-pushed
the
feature/2-file-component-type
branch
from
4a8916c to
f870581
Compare
Incorporate the configuration for the file uploads in the type. Added annotations because many of these are dynamically set by the backend or the calculated as part of the form builder form.
sergei-maertens
force-pushed
the
feature/2-file-component-type
branch
from
f870581 to
594f1e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes #2
This one is special, even in the case for 'multiple: false', the value is an array with only a single allowed item.
upstream Form.io file component allows many more upload targets, but we only support uploading to our own backend API. The upload configuration is generated and set dynamically by the backend, so that host names are not persisted in the JSON configuration.