Implement fieldset component schema type definition #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
force-pushed
the
feature/2-fieldset-type
branch
from
50d58fe to
7e8a064
Compare
Viicos
reviewed
Nov 30, 2023
Comment on lines
+14
to
+15
| * The label is displayed as the legend element, while the upstream component uses an | ||
| * explicit legend property for this purpose. |
There was a problem hiding this comment.
I'm not sure I understand this sentence:
-
The label is displayed as the legend element
legend == <legend>?
-
while the upstream component uses an explicit legend property for this purpose.
upstream = formio? What does explicit means here?
There was a problem hiding this comment.
- correct, this is about
<legend> - upstream = formio indeed, explicit as in
component.legendexists andcomponent.labelis actually ignored
There was a problem hiding this comment.
Ok nice, I'd be interested to see how this will be implemented on the form builder as I've used <fieldset> with <legend> as well.
Viicos
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes #2
Depends on #31