Implement types for signature component #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
changed the title
Viicos
reviewed
Dec 6, 2023
| * | ||
| * When a non-empty value is set, enforce that it is serialized as a data URI. | ||
| */ | ||
| export type SignatureValue = `data:image/png;base64,${string}`; |
There was a problem hiding this comment.
Imagine having this available in Python.. 🥹
There was a problem hiding this comment.
I find it a bit scary to be honest. And there doesn't seem to be a definitive way in TS to express that something is a non-empty string, so it's clearly still lacking a lot.
Viicos
approved these changes
Dec 6, 2023
sergei-maertens
force-pushed
the
feature/2-signature-type
branch
from
b754ac3 to
384b621
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes #2