Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# client applications do not close sockets. #1938

Open
mohandev2 opened this issue May 2, 2017 · 3 comments
Open

C# client applications do not close sockets. #1938

mohandev2 opened this issue May 2, 2017 · 3 comments

Comments

@mohandev2
Copy link
Collaborator

The README.windows file includes the message:
Seems client applications do not close sockets.
The sockets remain in TIME_WAIT state.
It can exhaust system resources.

Visual Studio code analysis when compiling openhpi_baselib.dll says:
CA1001 Types that own disposable fields should be disposable
Implement IDisposable on 'HpiTransport' because it creates members of the following IDisposable types: 'Socket'.
OpenHPI Baselib
HpiTransport.cs 25

It is possible that we need to add disposing code for the socket object in the C# HpiTransport class to fix the code analysis issue and to fix the sockets not closing problem.

Reported by: mgthompson

Original Ticket: openhpi/bugs/1938

@mohandev2
Copy link
Collaborator Author

  • 3.7.0: 3.7.0 --> 3.8.0

Original comment by: mohandev2

@mohandev2
Copy link
Collaborator Author

  • labels: --> OpenHPI Daemon

Original comment by: mohandev2

@mohandev2
Copy link
Collaborator Author

  • 3.7.0: 3.8.0 --> Future

Original comment by: mohandev2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants