Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: feedback - Default view for Stars and Forks graph should be time-series #3862

Open
jpmcb opened this issue Aug 5, 2024 · 4 comments

Comments

@jpmcb
Copy link
Member

jpmcb commented Aug 5, 2024

Suggested solution

We've gotten feedback that the default view for the stars and forks graph should be the time-series. Right now, when you go to a repo page, you'll see the histograms view:

Screenshot 2024-08-05 at 5 09 22 PM

This is valuable data. But it seems that people generally want to see "number go up" vs. trend / bucket data over a histogram. Here's that same repo page but with the time-series which shows a steady growth:

Screenshot 2024-08-05 at 5 10 28 PM


We'll want to decide if this is what we want to do or if we want to distinguish our platform with being opinionated for the histograms.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

@nickytonline
Copy link
Member

nickytonline commented Aug 7, 2024

Whoever takes this on, add some E2E tests for this as well. Happy to assist on E2E testing if needed.

@SURAJ-SHARMA27
Copy link
Contributor

Hi @jpmcb @nickytonline ,

I was working on the issue and resolved it locally, but before making a PR, I have a few suggestions. I created a line chart for the time series (see image 1), but I believe an area chart might be more suitable for this visualization (see image 2). What are your thoughts?

Additionally, I researched similar implementations on various sites. For example, GitHub has a Stargazers page where they display information about stargazers (see image 3). Could we consider implementing something similar with webhooks for each repository?
image

image

image

@jpmcb
Copy link
Member Author

jpmcb commented Aug 19, 2024

I do like the highlighted area under the time series - cc @isabensusan for final design signoff: if we made this change, we'd need to make it uniform across all time series charts (at least on the repo page: the stars and forks)

Go ahead and open a PR on this and we can play with it in a design preview.

Could we consider implementing something similar with webhooks for each repository?

Good suggestion! At this time, we're not interested in displaying who's starred a repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants