Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: extend "expect" timeouts in Playwright to 10,000ms #4072

Closed
jpmcb opened this issue Aug 29, 2024 · 2 comments · Fixed by #4102
Closed

Chore: extend "expect" timeouts in Playwright to 10,000ms #4072

jpmcb opened this issue Aug 29, 2024 · 2 comments · Fixed by #4102

Comments

@jpmcb
Copy link
Member

jpmcb commented Aug 29, 2024

Suggested solution

In an effort to make CI/CD and our dev experience better, we should consider extending the playwright "assertions" timeout:

await expect(locator).toBeHidden({ timeout: 10000 });

This is different from the global timeout we have configured:

timeout: process.env.CI ? 60000 : 30000,

A longer assertion timeout on frequently stalled tests in CI/CD help stabilize things in general.


Example timeout from CICD: https://github.com/open-sauced/app/actions/runs/10604426243/job/29391054608#step:7:400 and on the more powerful runner https://github.com/open-sauced/app/actions/runs/10623344087/job/29449581773?pr=4070

    Error: Timed out 5000ms waiting for expect(locator).toHaveAttribute(expected)

Related to #3946

Copy link
Contributor

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

Copy link
Contributor

open-sauced bot commented Sep 16, 2024

🎉 This issue has been resolved in version 2.63.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants