Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: excluded OSCR from old contributor card list component #3901

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Aug 8, 2024

Description

This PR excludes the OSCR score from the contributor card where the data being rendered does not include OSCR. Currently that is workspace repository insight contributor grids, and the explore page contributor grid.

OSCR will land in those two places with the new TanStack table component in the future. See #3819

Related Tickets & Documents

Relates to #3883

Mobile & Desktop Screenshots/Recordings

Steps to QA

  1. Visit a workspace repository insight contributor page
  2. Notice the grid does not include the OSCR scores.
  3. Visit the explore contributor page.
  4. Notice the grid does not include the OSCR scores.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 4dce7ce
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66b53214aac5840008e40718
😎 Deploy Preview https://deploy-preview-3901--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 4dce7ce
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66b53214b7edb600080ecad3
😎 Deploy Preview https://deploy-preview-3901--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline requested review from BekahHW and a team August 8, 2024 19:22
@nickytonline nickytonline changed the title fix: exlcuded OSCR from old contributor cardlist component fix: excluded OSCR from old contributor card list component Aug 8, 2024
@nickytonline nickytonline force-pushed the nickytonline/exclude-oscr-explore-page branch from 6bedd73 to 8feb238 Compare August 8, 2024 19:24
@nickytonline nickytonline merged commit 446f27c into beta Aug 8, 2024
13 checks passed
@nickytonline nickytonline deleted the nickytonline/exclude-oscr-explore-page branch August 8, 2024 21:06
open-sauced bot pushed a commit that referenced this pull request Aug 8, 2024
## [2.52.0-beta.9](v2.52.0-beta.8...v2.52.0-beta.9) (2024-08-08)

### 🐛 Bug Fixes

* excluded OSCR from old contributor card list component ([#3901](#3901)) ([446f27c](446f27c))
open-sauced bot pushed a commit that referenced this pull request Aug 9, 2024
## [2.52.0](v2.51.0...v2.52.0) (2024-08-09)

### 🍕 Features

* add OSCR tooltip to user page ([#3857](#3857)) ([fd5fa41](fd5fa41))
* add OSCR's location to PostHog capture ([#3895](#3895)) ([bbf8ee5](bbf8ee5))
* now OSCR appears on repository page contributor grid view ([#3884](#3884)) ([d7163d8](d7163d8))
* repository page contributor graph defaults to enhance by default now ([#3880](#3880)) ([90948a5](90948a5))
* tracking DevCard analytics ([#3874](#3874)) ([583e42a](583e42a))

### 🐛 Bug Fixes

* calculate avergage per week for ross contributors greater than 0 ([#3893](#3893)) ([a8859c5](a8859c5))
* excluded OSCR from old contributor card list component ([#3901](#3901)) ([446f27c](446f27c))
* now layout toggles are radio buttons ([#3888](#3888)) ([efba1f8](efba1f8))
* now the contributor card user profile link no longer affects the OSCR login flow ([#3898](#3898)) ([7405660](7405660))
* now the contributor scatter chart toggle group has a label ([#3882](#3882)) ([adf5c6c](adf5c6c))
* Removes NewsletterForm usage in favor of sole link to newsletter ([#3897](#3897)) ([61951ff](61951ff))
* repository insight limited features ([#3876](#3876)) ([5ef6bd6](5ef6bd6))
* show loading indicator for contributor confidence if undefined ([#3894](#3894)) ([3032a6a](3032a6a))
* update profile interests type to be optional and add guards ([#3890](#3890)) ([2e62773](2e62773))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants