-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: excluded OSCR from old contributor card list component #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nickytonline
changed the title
fix: exlcuded OSCR from old contributor cardlist component
fix: excluded OSCR from old contributor card list component
Aug 8, 2024
nickytonline
force-pushed
the
nickytonline/exclude-oscr-explore-page
branch
from
August 8, 2024 19:24
6bedd73
to
8feb238
Compare
BekahHW
approved these changes
Aug 8, 2024
jpmcb
approved these changes
Aug 8, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
## [2.52.0-beta.9](v2.52.0-beta.8...v2.52.0-beta.9) (2024-08-08) ### 🐛 Bug Fixes * excluded OSCR from old contributor card list component ([#3901](#3901)) ([446f27c](446f27c))
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
## [2.52.0](v2.51.0...v2.52.0) (2024-08-09) ### 🍕 Features * add OSCR tooltip to user page ([#3857](#3857)) ([fd5fa41](fd5fa41)) * add OSCR's location to PostHog capture ([#3895](#3895)) ([bbf8ee5](bbf8ee5)) * now OSCR appears on repository page contributor grid view ([#3884](#3884)) ([d7163d8](d7163d8)) * repository page contributor graph defaults to enhance by default now ([#3880](#3880)) ([90948a5](90948a5)) * tracking DevCard analytics ([#3874](#3874)) ([583e42a](583e42a)) ### 🐛 Bug Fixes * calculate avergage per week for ross contributors greater than 0 ([#3893](#3893)) ([a8859c5](a8859c5)) * excluded OSCR from old contributor card list component ([#3901](#3901)) ([446f27c](446f27c)) * now layout toggles are radio buttons ([#3888](#3888)) ([efba1f8](efba1f8)) * now the contributor card user profile link no longer affects the OSCR login flow ([#3898](#3898)) ([7405660](7405660)) * now the contributor scatter chart toggle group has a label ([#3882](#3882)) ([adf5c6c](adf5c6c)) * Removes NewsletterForm usage in favor of sole link to newsletter ([#3897](#3897)) ([61951ff](61951ff)) * repository insight limited features ([#3876](#3876)) ([5ef6bd6](5ef6bd6)) * show loading indicator for contributor confidence if undefined ([#3894](#3894)) ([3032a6a](3032a6a)) * update profile interests type to be optional and add guards ([#3890](#3890)) ([2e62773](2e62773))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR excludes the OSCR score from the contributor card where the data being rendered does not include OSCR. Currently that is workspace repository insight contributor grids, and the explore page contributor grid.
OSCR will land in those two places with the new TanStack table component in the future. See #3819
Related Tickets & Documents
Relates to #3883
Mobile & Desktop Screenshots/Recordings
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?