Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contributor insight card orange dot no longer squished #3912

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Aug 11, 2024

Description

Now the contributor insight card orange dot no longer gets squished.

Related Tickets & Documents

Fixes #3896

Mobile & Desktop Screenshots/Recordings

Before

CleanShot 2024-08-10 at 20 53 21

After

CleanShot 2024-08-10 at 20 52 44

Steps to QA

  1. Go to a contributor insight list, e.g. https://deploy-preview-3912--oss-insights.netlify.app/workspaces/21c5e583-f1fd-4033-9ec9-7801f67ff727/contributor-insights
  2. Resize the browser window to shrink it.
  3. Notice the orange dot no longer gets squished.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Aug 11, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit dec8636
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66b80b45e7c21b0008068fa3
😎 Deploy Preview https://deploy-preview-3912--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 11, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit dec8636
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66b80b4551c1680008e177ca
😎 Deploy Preview https://deploy-preview-3912--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline changed the title fix: contributor insight card orange dot no longer squishes fix: contributor insight card orange dot no longer squished Aug 11, 2024
@nickytonline nickytonline requested review from BekahHW and a team August 12, 2024 12:01
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickytonline nickytonline added this pull request to the merge queue Aug 12, 2024
Merged via the queue into beta with commit 01cb265 Aug 12, 2024
31 checks passed
@nickytonline nickytonline deleted the nickytonline/squish branch August 12, 2024 15:17
open-sauced bot pushed a commit that referenced this pull request Aug 12, 2024
## [2.53.1-beta.2](v2.53.1-beta.1...v2.53.1-beta.2) (2024-08-12)

### 🐛 Bug Fixes

* contributor insight card orange dot no longer squished ([#3912](#3912)) ([01cb265](01cb265))
open-sauced bot pushed a commit that referenced this pull request Aug 12, 2024
## [2.54.0](v2.53.0...v2.54.0) (2024-08-12)

### 🐛 Bug Fixes

* add margin left to prevent overflow of nav item ([#3904](#3904)) ([c8b8ace](c8b8ace))
* contributor insight card orange dot no longer squished ([#3912](#3912)) ([01cb265](01cb265))

### 🍕 Features

* update DevCard design ([#3879](#3879)) ([979576d](979576d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Long Titles for Contributor Insights Page distorts circle
3 participants