Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

feat: metrics chapter #68

Merged
merged 27 commits into from
Apr 4, 2024
Merged

feat: metrics chapter #68

merged 27 commits into from
Apr 4, 2024

Conversation

BekahHW
Copy link
Member

@BekahHW BekahHW commented Mar 14, 2024 •
edited by adiati98
Loading

Description

Metrics chapter.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

closes #67
closes #34

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@BekahHW BekahHW requested a review from a team as a code owner March 14, 2024 19:22
@adiati98
Copy link
Member

@BekahHW I only fixed the spacing, broken link to a gif, and add info alert here.
I haven't review the content. As the commit says, this is still a draft, right? Because the headings start with h3. 😅

@BekahHW
Copy link
Member Author

BekahHW commented Mar 14, 2024

Yes. This was just a braindump rough draft.

@BekahHW BekahHW requested a review from adiati98 March 28, 2024 18:03
adiati98
adiati98 reviewed Mar 28, 2024
View reviewed changes
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BekahHW, for now, I only have one comment.
Is this ready to review? If so, review this tomorrow. Thanks! 😊

assets/img/list-graph.png Outdated Show resolved Hide resolved
@BekahHW
Copy link
Member Author

BekahHW commented Mar 28, 2024

@adiati98 it's ready

adiati98
adiati98 suggested changes Mar 28, 2024
View reviewed changes
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BekahHW

I left some reviews here.
Some are for clarity purpose, and some for sections and headings questions.

Thank you. 😊

metrics-and-analytics.md Outdated Show resolved Hide resolved
metrics-and-analytics.md Outdated Show resolved Hide resolved
metrics-and-analytics.md Outdated Show resolved Hide resolved
metrics-and-analytics.md Outdated Show resolved Hide resolved
metrics-and-analytics.md Outdated Show resolved Hide resolved
metrics-and-analytics.md Outdated Show resolved Hide resolved
metrics-and-analytics.md Show resolved Hide resolved
metrics-and-analytics.md Outdated Show resolved Hide resolved
metrics-and-analytics.md Outdated Show resolved Hide resolved
metrics-and-analytics.md Outdated Show resolved Hide resolved
@BekahHW BekahHW requested a review from adiati98 April 3, 2024 19:39
adiati98
adiati98 reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BekahHW, I left a review for your thought here.

Other than this, I approved this PR. 🚀

metrics-and-analytics.md Outdated Show resolved Hide resolved
@adiati98 adiati98 merged commit 0c5dc46 into main Apr 4, 2024
@adiati98 adiati98 mentioned this pull request Apr 11, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adiati98 adiati98 adiati98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add workspaces feat: Analytics and Metrics Chapter
2 participants
@BekahHW @adiati98