Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Make pizza oven service deployable/buildable to 32 bit systems #23

Open
jpmcb opened this issue Jul 20, 2023 · 0 comments
Open

Comments

@jpmcb
Copy link
Member

jpmcb commented Jul 20, 2023

Currently, the minimum free disk env variable is parsed as uint64:

pizza/main.go

Lines 71 to 78 in 51ed9ca

// Validates the provided minimum free disk int is parsable as a uint64
//
// TODO - should dynamically check file system bit size after compilation.
// 64 bit wide words should be fine for almost all use cases for now.
minFreeDiskUint64, err := strconv.ParseUint(minFreeDisk, 10, 64)
if err != nil {
sugarLogger.Fatalf(": %s", err.Error())
}

This is mostly fine since I'd imagine we're only going to deploy this to 64 bit systems.

A stretch goal / nice to have someday would be to make this dynamic for the system that is being compiled to. I think this would be a simple check against bits.UintSize (which should be set at compile time).

The tricky part will be cross building images on different machines with the right bit lengths.

But again, I anticipate only really needing 64 bit systems, so this is a stretch goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant