Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: overall imporve error / logging handling #49

Open
2 tasks done
jpmcb opened this issue Sep 11, 2023 · 1 comment
Open
2 tasks done

Tracking issue: overall imporve error / logging handling #49

jpmcb opened this issue Sep 11, 2023 · 1 comment
Assignees

Comments

@jpmcb
Copy link
Member

jpmcb commented Sep 11, 2023

Type of feature

🍕 Feature

Current behavior

There are a few places where error handling leaves abit to be desired. For example:

pizza/pkg/server/server.go

Lines 177 to 180 in f0071a5

ref, err := gitRepo.Head()
if err != nil {
return err
}

Suggested solution

Overall, we should be using tiered / structured logging so we always know where an error may have occurred. We should back-fill areas that may be missing this

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@k1nho
Copy link
Contributor

k1nho commented Sep 12, 2023

I can pick this one.

@k1nho k1nho mentioned this issue Sep 16, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants