change from seconds to ns

open-telemetry · Oct 17, 2024 · 17f6908 · 17f6908
1 parent 6d14f57
commit 17f6908
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 18 deletions.
diff --git a/receiver/ntpreceiver/documentation.md b/receiver/ntpreceiver/documentation.md
@@ -14,11 +14,11 @@ metrics:
 
 ### ntp.offset
 
-Time difference between local and NTP server clocks in seconds.
+Time difference between local and NTP server clocks
 
 | Unit | Metric Type | Value Type |
 | ---- | ----------- | ---------- |
-| s | Gauge | Double |
+| ns | Gauge | Int |
 
 ## Resource Attributes
 

diff --git a/receiver/ntpreceiver/generated_package_test.go b/receiver/ntpreceiver/generated_package_test.go
diff --git a/receiver/ntpreceiver/internal/metadata/generated_metrics.go b/receiver/ntpreceiver/internal/metadata/generated_metrics.go
diff --git a/receiver/ntpreceiver/internal/metadata/generated_metrics_test.go b/receiver/ntpreceiver/internal/metadata/generated_metrics_test.go
diff --git a/receiver/ntpreceiver/metadata.yaml b/receiver/ntpreceiver/metadata.yaml
@@ -16,10 +16,10 @@ resource_attributes:
 
 metrics:
   ntp.offset:
-    description: Time difference between local and NTP server clocks in seconds.
-    unit: "s"
+    description: Time difference between local and NTP server clocks
+    unit: "ns"
     gauge:
-      value_type: double
+      value_type: int
     enabled: true
 
 tests:
diff --git a/receiver/ntpreceiver/receiver.go b/receiver/ntpreceiver/receiver.go
@@ -30,8 +30,7 @@ func (s *scraper) scrape(context.Context) (pmetric.Metrics, error) {
 	if err != nil {
 		return pmetric.Metrics{}, err
 	}
-	clockOffset := response.ClockOffset.Seconds()
-	s.mb.RecordNtpOffsetDataPoint(pcommon.NewTimestampFromTime(time.Now()), clockOffset)
+	s.mb.RecordNtpOffsetDataPoint(pcommon.NewTimestampFromTime(time.Now()), response.ClockOffset.Nanoseconds())
 	s.mb.NewResourceBuilder().SetNtpHost(s.endpoint)
 	return s.mb.Emit(), nil
 }