From 79926f8647a9839cb2020aeddbcc33a248ed7422 Mon Sep 17 00:00:00 2001 From: Yang Song Date: Mon, 21 Oct 2024 14:22:49 -0400 Subject: [PATCH] [chore] skip encoded-compare in testifylint (#35900) --- .golangci.yml | 1 + Makefile.Common | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index bf8564d6a445..e7d4a3846078 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -137,6 +137,7 @@ linters-settings: - float-compare - require-error - suite-subtest-run + - encoded-compare # has false positives that cannot be fixed with testifylint-fix enable-all: true linters: diff --git a/Makefile.Common b/Makefile.Common index f73df4c03097..07ce7e0d9062 100644 --- a/Makefile.Common +++ b/Makefile.Common @@ -78,7 +78,7 @@ GOTESTSUM := $(TOOLS_BIN_DIR)/gotestsum TESTIFYLINT := $(TOOLS_BIN_DIR)/testifylint GOTESTSUM_OPT?= --rerun-fails=1 -TESTIFYLINT_OPT?= --enable-all --disable=float-compare,require-error,suite-subtest-run +TESTIFYLINT_OPT?= --enable-all --disable=float-compare,require-error,suite-subtest-run,encoded-compare # BUILD_TYPE should be one of (dev, release). BUILD_TYPE?=release