[exporter/clickhouse] Upgrade trace table #34245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Frapschen and @hanjm please review as codeowners |
Frapschen
reviewed
Aug 6, 2024
Frapschen
reviewed
Aug 6, 2024
hanjm
reviewed
Aug 6, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Not stale 👉 Collecting feedback internally/externally, will update soon. Thanks! |
SpencerTorres
force-pushed
the
update-trace-table
branch
from
105c186 to
43aed9d
Compare
SpencerTorres
force-pushed
the
update-trace-table
branch
from
c1d71a8 to
6978697
Compare
SpencerTorres
force-pushed
the
update-trace-table
branch
from
f4bdbe4 to
77496ad
Compare
hanjm
approved these changes
Sep 15, 2024
|
@Frapschen @dmitryax Looking to get this and #35186 merged before next release, let me know if this looks good. They're pretty small changes |
dmitryax
approved these changes
Sep 25, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
This PR updates the default `otel_traces` table schema. There are no breaking changes, this schema is compatible with the previous `INSERT` statement. This does not affect existing users, only new users that have `create_schema` enabled in the config. Notable changes: - Optimized ORDER BY to use a 32 bit DateTime without TraceId - Reduced DateTime64(9) to DateTime on the trace timestamp table - TTLs now use Date instead of DateTime since parts will only be dropped on the partition date No major column changes for now, but there were some small performance benefits observed with these changes. As always, it is best to edit these tables to fit your needs and query patterns. I expect further changes in the future as we continue to optimize this table for a generalized use case. **Testing:** Integration tests are disabled, but I enabled them locally to test that this change works as intended. Unit tests are passing as well. **Documentation:** - Updated README - Example DDL has been updated, and now includes the trace timestamp table and materialized view --------- Co-authored-by: Dmitrii Anoshin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the default
otel_tracestable schema.There are no breaking changes, this schema is compatible with the previous
INSERTstatement. This does not affect existing users, only new users that havecreate_schemaenabled in the config.Notable changes:
No major column changes for now, but there were some small performance benefits observed with these changes.
As always, it is best to edit these tables to fit your needs and query patterns. I expect further changes in the future as we continue to optimize this table for a generalized use case.
Testing:
Integration tests are disabled, but I enabled them locally to test that this change works as intended.
Unit tests are passing as well.
Documentation: