Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] Change default retry.retry_to_status to [429] #34684

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

carsonip
Copy link
Contributor

@carsonip carsonip commented Aug 14, 2024

Description:

Breaking change to change default retry_on_status to 429

Link to tracking Issue:
Fixes #32584

Testing:

Documentation:

@carsonip carsonip marked this pull request as ready for review August 14, 2024 14:44
@carsonip carsonip requested review from a team and songy23 August 14, 2024 14:44
@crobert-1
Copy link
Member

Can you also add to your PR description that this is related to (or even Resolves if true) #32584?

@crobert-1
Copy link
Member

My approval stands, if we could get another code owner approval that would be great. Otherwise I can add ready to merge after a few more days have passed to give others a chance to review.

@andrzej-stencel andrzej-stencel merged commit a19aa30 into open-telemetry:main Aug 23, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 23, 2024
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
open-telemetry#34684)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Breaking change to change default retry_on_status to 429

**Link to tracking Issue:** <Issue number if applicable>
Fixes
open-telemetry#32584

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exporter/elasticsearch] Make retry statuses configurable and default to 429 only
3 participants