Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce windowseventlogreceiver tests flakiness #34791

Conversation

pjanotti
Copy link
Contributor

Description:
There are 3 main issues being addressed on this PR:

  • There is a race between start and generating the events in the tests: the start require goroutines so a delay before generating the events will be advisable (not perfect but good enough per my tests)
  • The tests assume that only the tests are generating events in that time window, that is impossible to guarantee on a windows box, so instead of checking for exactly one event they need to get new events and check the event provider instead
  • The exclusion test checks if zero events were delivered by the receiver, it should check if one not filtered out was received, and this one should be generated after the event from the provider that should be excluded.

Link to tracking Issue:
Fixes #34687

Testing:
Multiple local runs, we should do a few runs on CI given the runner characteristics.

Documentation:
N/A

@pjanotti
Copy link
Contributor Author

/label os:windows

@crobert-1 crobert-1 added Run Windows Enable running windows test on a PR os:windows labels Aug 21, 2024
TylerHelmuth and others added 5 commits August 21, 2024 10:30
**Description:** 
Updates core libraries to latest version.

Adjust for `componentstatus.InstanceID` breaking changes

---------

Signed-off-by: Tyler Helmuth <[email protected]>
Co-authored-by: Matthew Wear <[email protected]>
…om:pjanotti/opentelemetry-service-contrib into fix-windowseventlogreceiver-test-flakiness
@pjanotti
Copy link
Contributor Author

Did not intend for all the go.mod changes, closing until that is cleaned up.

@pjanotti pjanotti closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/windowseventlog] Flaky test TestReadWindowsEventLogger
4 participants