[receiver/prometheus] Fix static scrape config with Target Allocator #36063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. Can you please add a test? |
|
@atoulme added a test 👍 |
dashpole
approved these changes
Nov 12, 2024
dashpole
added
the
ready to merge
TylerHelmuth
approved these changes
Nov 18, 2024
RutvikS-crest
pushed a commit
to RutvikS-crest/opentelemetry-collector-contrib
that referenced
this pull request
Dec 9, 2024
…pen-telemetry#36063) #### Description Instead of clearing out prometheus scrape configuration I changed the code to copy the initial config every time we sync it from Target Allocator #### Link to tracking issue Fixes open-telemetry#36062 and open-telemetry/opentelemetry-operator#3034 <!--Describe what testing was performed and which tests were added.--> #### Testing tested in kind cluster with custom image <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Co-authored-by: David Ashpole <[email protected]>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…pen-telemetry#36063) #### Description Instead of clearing out prometheus scrape configuration I changed the code to copy the initial config every time we sync it from Target Allocator #### Link to tracking issue Fixes open-telemetry#36062 and open-telemetry/opentelemetry-operator#3034 <!--Describe what testing was performed and which tests were added.--> #### Testing tested in kind cluster with custom image <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Co-authored-by: David Ashpole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of clearing out prometheus scrape configuration I changed the code to copy the initial config every time we sync it from Target Allocator
Link to tracking issue
Fixes #36062 and open-telemetry/opentelemetry-operator#3034
Testing
tested in kind cluster with custom image
Documentation